search

private-octopus / picoquic

Minimal implementation of the QUIC protocol
MIT License
527 stars 156 forks source link

Verify reported crash does not repro. #1529

Closed huitema closed 1 year ago

huitema commented 1 year ago

There was a potential crash reported in issue #1527. It turns out that the test was conducted on a previous version of Picoquic, and that the issue was already fixed. The additional test verifies that.

huitema commented 1 year ago

Analysis of the issue pointed out the misleading names of the pointers for the queue of packets awaiting ack or retransmission. Applying a set of name changes to reverse that:

Old name what new name
pkt_ctx->retransmit_newest the last packet inserted in the queue of packets waiting ACK or retransmit pkt_ctx->pending_last
pkt_ctx->retransmit_oldest the oldest packet in the queue pkt_ctx->pending_first
packet->next_packet pointer to the previous packet in the queue packet->packet_previous
packet->previous_packet pointer to the next packet in the queue packet->packet_next