private-octopus / picoquic

Minimal implementation of the QUIC protocol
MIT License
546 stars 161 forks source link

Changes in draft-18 #506

Closed huitema closed 5 years ago

huitema commented 5 years ago

In transport:

alagoutte commented 5 years ago

You can look also the "TODO draft-18" item list for @wireshark https://github.com/quicwg/base-drafts/wiki/Tools

huitema commented 5 years ago

Looking at this change list, it seems that the only changes affecting the bits on the wire are: 1) STREAM_STATE_ERROR - already implemented 2) Limit Retry and Version Negotiation to once per datagram -- already implemented 3) Set a maximum value for max_ack_delay transport parameter -- done in PR #514 4) Allow server preferred address for both IPv4 and IPv6 -- done in PR #514.

ALPN is a server configuration issue, and the "or equivalent" clause is ambiguous. The Picoquic client always provide an ALPN.

We already have code to not process the Initial packets when in Handshake or Ready state, so there is no point in actually discarding the Initial keys. We discussed this in Tokyo, and a better solution is supposed to arrive with draft-19.

The recovery recommendation are interesting, but I am notsure that they apply to our implementation.

huitema commented 5 years ago

Done in PR #514