search

privateOmega / html-to-docx

HTML to DOCX converter
MIT License
389 stars 143 forks source link

feat: add default list styles option #160

Closed nicolasiscoding closed 1 year ago

nicolasiscoding commented 1 year ago

Good catch

Sent via Superhuman iOS @.***>

On Thu, Nov 10 2022 at 11:59 AM, Kiran Mathew Mohan < @.***> wrote:

@.**** requested changes on this pull request.

@nicolasiscoding https://github.com/nicolasiscoding Please resolve your unresolved threads as well. I see that the changes were pushed out.

In src/utils/list.js https://github.com/privateOmega/html-to-docx/pull/160#discussion_r1019393748 :

  • case 'decimal':
  • case 'decimal-bracket':
  • default:
  • return this.defaults.defaultOrderedListStyleType;
  • }

this looks wrong

for case 'decimal' and 'decimal-bracket' it should be 'decimal' and for the case where its not explicitly specified, it should use this.defaults.defaultOrderedListStyleType

— Reply to this email directly, view it on GitHub https://github.com/privateOmega/html-to-docx/pull/160#pullrequestreview-1176166904, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHLNTSMNNOMDWN3UQDWZKDWHUSV5ANCNFSM6AAAAAARZ3LBUA . You are receiving this because you were mentioned.Message ID: @.***>