Open RoxnnyABarriosC opened 3 years ago
@RoxnnyABarriosC Please raise a PR with this typescript definition, and also do we need any sort of typescript configuration to make use of this definition?
I believe that in order to use typed definitions, you need to open a PR at https://github.com/DefinitelyTyped/DefinitelyTyped
. That will allow users to import @types/html-to-docx
. These definitions looks alright to me, @privateOmega , are they alright with you? If so, then either @RoxnnyABarriosC or I can open a PR on DefinitelyTyped
.
@ndrewtl Not exactly, Definitely typed is a huge mono-repo hosting type definitions for different package and has deployment strategies to deploy the type definitions of each package separately.
I would be very happy to see the entire package migrated to typescript as well, but time is an issue. But if one you could take it up, I could probably assist, else you can raise a PR to this package itself, specifying "types" field in package.json. The benefit of us keeping the ts definition file inside the repo, also helps keeping it in sync in case any apis change as well.
Any updates on this ?
@privateOmega RE: typescript. I've created a branch converted to typescript. It's working locally, if useful I can do up a PR. https://github.com/jafin/html-to-docx/tree/feat/typescript
@jafin when will this PR be up ? it looks promising.
As a workaround, you can use
// @ts-ignore
any update on this?