privatenumber / pkgroll

📦 Zero-config package bundler for Node.js + TypeScript
MIT License
1.01k stars 23 forks source link

fix: support `preserveSymlinks` in `tsconfig.json` #71

Open jrson83 opened 5 days ago

jrson83 commented 5 days ago

I have tried to implement realPath conditionally where it is used.

However, I realized that it is ultimately up to rollup-plugin-dts, which uses ts.sys but does not implement realpathSync, to fix the problem.

So we should set preserveSymlinks: false as default.

I have written a test which mimics pnpm symlinks and fails without preserveSymlinks: false.

Closes #69

jrson83 commented 2 days ago

@privatenumber anything holding back?