search

privatenumber / snap-tweet

Snap a screenshot of a tweet 📸
MIT License
343 stars 19 forks source link

Produced image/snap doesn't show replies, RT's and likes... instead shows "Read 10.1k replies" #21

Closed Zcehtro closed 2 years ago

Zcehtro commented 2 years ago

Bug description

What did you do? (Provide code in next section) Took a snap of a tweet of one of the built-in examples. @jack's tweet #20.

What did you expect to happen? For the snap to appear as in the READ.ME on the git page.

What happened instead? The program executes correctly on the CLI. But, in the produced snap, instead of there showing an

separator and then the replies, rt's and likes.. there's a button that says Read XX replies.

Do you have an error stack-trace? Don't know what this is, but I'll get it if it can be explained to me :)

Reproduction

Provide one of the following:

  1. snap-tweet https://twitter.com/jack/status/20
  2. ??
  3. Sharing snap instead:

snap-tweet-jack-20 FYI I am not logged in to twitter on the browser, but I doubt that has any effect.

Environment

Zcehtro commented 2 years ago

Same issue as in https://github.com/privatenumber/snap-tweet/issues/19 I suppose.

privatenumber commented 2 years ago

Thanks for the issue. It should work fine now:

npx snap-tweet https://twitter.com/jack/status/20

snap-tweet-jack-20

FYI the issue with Node v17 is also fixed if you want to go back to using it.

BTW, interesting that your image is significantly lower quality than mine, and the corners are black instead of transparent. I wonder what could be affecting that.

Zcehtro commented 2 years ago

The black borders are because I was opening it in irfanview. Irfanview uses by default a black background but doesn't handle transparency well when saving new images. I assume therefore the tweet border is transparent.

Regarding the resolution of the image, I haven't got a clue... 🤨

You know... something happened now and I can't take a snap. I'll open a new ticket... 😶

Zcehtro commented 2 years ago

Something was happening that I couldn't take a snap, the program froze every time, stuck in the CLI with the message like taking a snap but it never changed. Somehow it resolved itself.. Maybe I needed to reopen the shell for installation changes to take effect... who knows.