fix: use react v16.8.0 - Githubissues

privatenumber / snap-tweet

Snap a screenshot of a tweet 📸

MIT License

343 stars 19 forks source link

fix: use react v16.8.0 #3

Closed privatenumber closed 3 years ago

privatenumber commented 3 years ago

Problem

Closes https://github.com/privatenumber/snap-tweet/issues/1

Seems this problem is due to npm 7 enforcing strict peer dependencies.

A nested dependency ink -> react-reconciler sets react as a peer dependency using semver ^16.0.0, whereas ink sets it as >=16.8.0.

snap-tweet was installing react 17.0.2, so the version of react that snap-tweet used, and the version of react ink used were different.

Changes

Lower react dependency to 16.8.0 to meet peer dependency requirement
Bundle in react and ink so that dependencies are locked in
- This also increases the distribution size quite dramatically, but, speeds up installation size
- Externalized yoga-layout-prebuilt due to a runtime error. Relevant issue: https://github.com/vadimdemedes/yoga-layout-prebuilt/issues/2

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: