tsx >= 4.15.0 breaks playwright code

RunOrVeith commented 3 days ago

Acknowledgements

[X] I read the documentation and searched existing issues to avoid duplicates
[X] I understand this is a bug tracker and anything other than a proven bug will be closed
[X] I understand this is a free project and relies on community contributions
[X] I read and understood the Contribution guide

Minimal reproduction URL

https://github.com/RunOrVeith/tsxPlaywrightBug

Problem & expected behavior (under 200 words)

I opened an issue with more information in playwright, but this is probably a tsx/esbuild issue.

Bugs are expected to be fixed by those affected by it

[ ] I'm interested in working on this issue

Compensating engineering work will speed up resolution and support the project

[ ] I'm willing to offer $10 for financial support

privatenumber commented 3 days ago

Im not able to look into this yet but I took a glance at the reproduction and it didnt look minimal.

Can you remove anything that isnt necessary to reproduce the error?

RunOrVeith commented 3 days ago

No, sorry. This is as minimal as I can make it. I was unable to reproduce it with less than that. It's only a few lines, but of course the playwright implementation is more. Playwright is somehow serializing the code inside addInitScript and sending it to the browser. But this is a tsx issue because it works with node. The steps to reproduce are (inside my example repo):

npm i
npx playwright install
npx tsx index.ts

The problem is also resolved with the workaround in https://github.com/evanw/esbuild/issues/2605#issuecomment-2146054255, so this might be a duplicate

privatenumber / tsx