Closed aquajach closed 1 month ago
It's marked as a breaking change here: https://github.com/evanw/esbuild/releases/tag/v0.24.0
Unless you can give me a real reason for upgrading than "good practice to stay up to date", I'll be closing these PRs as it creates unnecessary work for me and has no impact on users.
Closing as a duplicate of https://github.com/privatenumber/tsx/pull/664
Thanks for maintaining this project!
Read and understood the reason behind closing another PR . But I would still like to submit this one because:
esbuild
in our ownpackage.json
to work around them, but user experience suffers, especially have impact to new users oftsx
who also care about vulnerabilities.esbuild
release is no longer withbreaking change
label.esbuild-wasm
crash coming from a bug inmemchr
https://github.com/evanw/esbuild/pull/3902To be honest, none of them alone solves a critical problem of
tsx
itself but I hope with all together makes the impact bigger.We all understand it is a good practice to keep dependencies up to date to a certain level with cautiousness. Comparing to big version jumps, I think smaller incremental hips is less risky for long run, although brings a bit of more work to do from maintainers' point of view.