search

privefl / bigsnpr

R package for the analysis of massive SNP arrays.
https://privefl.github.io/bigsnpr/
183 stars 43 forks source link

OpenMP flag is not passed #418

Closed barracuda156 closed 1 year ago

barracuda156 commented 1 year ago

Same issue as here: https://github.com/privefl/bigstatsr/issues/162

Makevars has $(SHLIB_OPENMP_CXXFLAGS), but it does nothing, apparently because there is no configure to determine correct flags. To make it work, there should be a test for support for OpenMP, conditional on compiler used, and then GCC needs -fopenmp, while Clang also needs -lomp in addition to the former (user may have to specify then the location of libomp, if Clang is used, since different package managers install it in different locations).

privefl commented 1 year ago

Let's use only one issue, discuss in the other one.