The login dialog for the privly-applications currently has only one error message if the user fails to login. This is a problem because it fails to separate bad passwords from server errors. checkCredentials in new.js should be modified to check for an error status code. I think adding a check for response.json.error === true and then calling the appropriate callback should work, callbacks.loginFailure().
This is an introductory issue, but I expect it still to be challenging for people because the design considerations are different from most JS applications. The easiest way to get started is to clone the privly-chrome repository with git clone --recursive https://github.com/privly/privly-chrome.git. This will clone the privly-applications repository inside the Chrome extension and allow you to make changes to the privly-applications/Login/js/new.js. You will need to load an unpacked extension to get the code into Chrome.
To launch the login dialog with the extension's version of the form you should initiate a posting process by right clicking on a form element on a page and selecting "post with ZeroBin". This will prompt you to login and you can view the form.
This task should give you a better idea of what local code and remote code are in the Privly ecosystem.
smcgregor
commented
9 years ago
The login dialog for the privly-applications currently has only one error message if the user fails to login. This is a problem because it fails to separate bad passwords from server errors.
checkCredentialsin new.js should be modified to check for an error status code. I think adding a check forresponse.json.error === trueand then calling the appropriate callback should work,callbacks.loginFailure().This is an introductory issue, but I expect it still to be challenging for people because the design considerations are different from most JS applications. The easiest way to get started is to clone the privly-chrome repository with
git clone --recursive https://github.com/privly/privly-chrome.git. This will clone the privly-applications repository inside the Chrome extension and allow you to make changes to theprivly-applications/Login/js/new.js. You will need to load an unpacked extension to get the code into Chrome.To launch the login dialog with the extension's version of the form you should initiate a posting process by right clicking on a form element on a page and selecting "post with ZeroBin". This will prompt you to login and you can view the form.
This task should give you a better idea of what local code and remote code are in the Privly ecosystem.