search

privly / privly-applications

The central repository for Privly Injectable Applications.
MIT License
19 stars 48 forks source link

Seamless posting can produce inconsistent whitespace #288

Open irdan opened 9 years ago

irdan commented 9 years ago

I discovered this using seamless posting in gchat. If a user types a message and then moves the cursor into the middle of a word and hits enter the message is submitted with a space in the middle of the word.

So instead of seeing this is my message, if the cursor was in the middle of message, it would be submitted as this is my mess age.

opg7371 commented 8 years ago

@irdan can you give me some steps to produce this error. I am using firefox and gchat and after i sent the same message to another one.,there was no space in the middle of the word.

smcgregor commented 8 years ago

I can describe why this might happen.

Some web forms submit when you hit "enter", but others do not. In one case you want to insert a newline character, and in the other you want to submit the form containing the privly link. This ambiguity is resolved by putting a link into the form and continually updating the enciphered content stored on the server until the form is submitted. Every "enter" key is forwarded onto the form element underneath to give the host page an opportunity to submit.

There may be a race condition where the key is forwarded to the form element, then the enter key is enciphered and sent to the remote server. If the form is submitted by the enter key, then we don't want the remote content to update.

opg7371 commented 8 years ago

I just want to know in which segment can i find the code for the seamless injecting... I mean the main algorithm since that would give me the better understanding of the different functions execution

smcgregor commented 8 years ago

You might start here, but I would recommend tackling a different issue first. This one will take you at least a month to get through since you need to learn about several JS libraries, the build system, the content scripts, etc. Better options would be:

opg7371 commented 8 years ago

regarding Improve the footer at the bottom of the privly-applications ., 1- I want to add a textbox(to take email id) for subscribing to our mailing list or some latest things that we have implemented. 2-link to twitter,facebook,and main website if that's okay . Also I would like you suggest some more things that you want to be implemented.

Screenshot attached in the below comment:

opg7371 commented 8 years ago

privly_app

opg7371 commented 8 years ago

Also i am thinking of adding a small map describing our location at the right corner.. Please tell me about if there is anything more to know

smcgregor commented 8 years ago
opg7371 commented 8 years ago

So is there anything extra which i can add to improve the footer I will take part of the youtube and linkedin part and also for the form.

smcgregor commented 8 years ago

My immediate suggestion would be to separate the terms/DMCA part since that does not need to be very prominent. Then we could potentially remove the "Donate" part, and place a donation link prominently on the "Learn More" page.

How about you survey footers from around the web for design inspiration?

opg7371 commented 8 years ago

complete footer part here: #318