search

privly / privly-applications

The central repository for Privly Injectable Applications.
MIT License
19 stars 48 forks source link

Feature improve footer #321

Closed opg7371 closed 8 years ago

opg7371 commented 8 years ago

This is for the improved footer of the privly-application.

smcgregor commented 8 years ago

@irdan commented on the other pull request, same thing here. You need to keep the commits for each feature in different branches, otherwise it breaks the review process.

opg7371 commented 8 years ago

How do i do that..keeping the different commits in different branches. Once i open a pull request.,then automatically all the commits are approved pardon me if this is common issue

smcgregor commented 8 years ago

Since you already mixed the commits, you will likely need to create feature branches from the develop branch, then cherry pick the commits that should be on each feature branch from the branches of your current pull request.

You might need to read a primer on git workflows. It is something you must know in both open source and corporate settings. Atlassian has some pretty good guides.