search

privly / privly-applications

The central repository for Privly Injectable Applications.
MIT License
19 stars 48 forks source link

build.py #322

Closed opg7371 closed 8 years ago

opg7371 commented 8 years ago

Build.py is compatible with python3. The main problem was that the prettyHTML is converted to bytes and to make it run we decode it back to 'str'.So Now the lines that i have changed is 70-72 and converted them to the lines 70-78.

smcgregor commented 8 years ago

This looks good upon inspection. I'll test and merge to develop. Please note that pull requests should be made against the "develop" branch.

opg7371 commented 8 years ago

So should i again make the pull request against the develop branch

smcgregor commented 8 years ago

No, I'll merge to develop then manually close this PR.

smcgregor commented 8 years ago

Did you have issues with pip3 install -r? I am installing the requirements for Python 3 for the first time.

opg7371 commented 8 years ago

i did not used the pip3 install -r since all the required modules were pre-installed on my system. Also i did ran it now and it is working fine.there are no issues in my system