search

privly / privly-applications

The central repository for Privly Injectable Applications.
MIT License
19 stars 48 forks source link

Injected Privly apps more like Github #361

Open prastut opened 8 years ago

prastut commented 8 years ago

If I use Privly inside Github and use a coding reference, it doesn't show.

For eg: If I type
<title>Privly · &lt;i class="fa fa-github"&gt;&lt;/i&gt; Open Source</title> Privly renders it without ``

@smcgregor details the following problem: The screen capture below shows the HTML for the injected content above. It is wrapping the code in the code block, but since the injected iframe does not inherit the stylesheets of GitHub it does not display code blocks the same as GitHub. 06da9dfc-dd42-11e5-9cbc-0b5f459f76d6

Stylesheet needs to be updated.

smcgregor commented 8 years ago

I would say this is more something that could look better than an actual bug. The current design choice was made because we want the injected content to be as seamless with the surrounding content as possible. GitHub is only one site the content is displayed within, so saying it should change means you are saying that there is a way for it to look better on all websites-- not just GitHub.

prastut commented 8 years ago

@smcgregor This could extend the User Experience project in a minute way as far as I can tell. To increase more use-cases for Privly in that context.

prastut commented 8 years ago

This can even be extended to emails. Right now every field requires to input info in Privly. It should be one application to send all data. Data indifference could be applied here I guess, since all email apps require to:, subject:., body:.