search

privly / privly-jetpack

A development repo for porting privly-firefox to Jetpack
MIT License
4 stars 9 forks source link

Extension built using jpm, not cfx #2

Closed hitesh96db closed 9 years ago

irdan commented 9 years ago

Is this ready for review? I get four warnings when trying to run the extension with jpm run but it may be an issue with my environment.

Are you intending on adding the functionality in #1 here or in a future PR?

hitesh96db commented 9 years ago

I'll add #1 in a future PR.

hitesh96db commented 9 years ago

@irdan Added the instructions

hitesh96db commented 9 years ago

Updated the description as mentioned by Sean.

irdan commented 9 years ago

I am :+1: to merging this. Right now the extension is built using jpm but does nothing.

@smcgregor thoughts?

smcgregor commented 9 years ago

Looks good to me. Are we going to develop under the assumption of the current version of FF nightly? I am good with this if there are any benefits over legacy support.

irdan commented 9 years ago

I assume this is in reference to specifying FF38 instead of FF37 in development.md? The reason for making that assumption is that jpm, which is the 'official' way to build extension currently, only officially supports FF38.

smcgregor commented 9 years ago

As in, the package won't run on previous versions? I had assumed JPM was somehow integrated with nightly but the built package would still run on older versions. I don't think this is actually a problem since we don't support old FF versions explicitly, I am just curious.

irdan commented 9 years ago

jpm is targeted at supporting 'FF38 and ownards'. It is just a node.js library that uses whichever version of firefox that you point it at.

smcgregor commented 9 years ago

ok, thanks.