privly / privly-jetpack

A development repo for porting privly-firefox to Jetpack
MIT License
4 stars 9 forks source link

Options interface and context messenger, Added user whitelist #8

Closed hitesh96db closed 9 years ago

hitesh96db commented 9 years ago

Uses the options interface and context messenger. Depends on https://github.com/privly/privly-applications/pull/275

hitesh96db commented 9 years ago

@smcgregor Pushed a new commit.

hitesh96db commented 9 years ago

@smcgregor Now it takes only O(n) script references to load the Privly namespace in the background scripts :)

hitesh96db commented 9 years ago

@smcgregor Any updates on this ?

smcgregor commented 9 years ago

I think this will likely be OK. A few pull requests are nearing merge, which are your highest priorities?

hitesh96db commented 9 years ago

My plan for the coming week -- 1) Fix tc_message.rb for Jetpack.(test fails because of the architecture difference. So I'll open a PR to fix it.) 2) Set up privly-jetpack on SauceLabs. 3) Add the boiler plate for code coverage.

I've done most of the work for 1) and 3). But it's better if I open the PR for 1) once this one and the corresponding privly-applications one gets merged.

hitesh96db commented 9 years ago

I also need to fix the unit tests once this gets merged. (I intend to send all pending PR's before 17th).