search

privly / privly-safari

Official Safari Browser Extension
https://priv.ly
MIT License
13 stars 5 forks source link

Added basic .travis.yml #16

Closed sambuddhabasu closed 9 years ago

sambuddhabasu commented 9 years ago

Added .travis.yml for Travis CI builds

smcgregor commented 9 years ago

Can you link me to this running on travis?

sambuddhabasu commented 9 years ago

@smcgregor The builds can be seen at https://travis-ci.org/sammyshj/privly-safari/builds/64028422 and https://travis-ci.org/sammyshj/privly-safari/builds/64028541

sambuddhabasu commented 9 years ago

I am looking at why the tests are failing now. Once the tests pass, you can review the code and I will squash the commits so that the PR can be merged

sambuddhabasu commented 9 years ago

@smcgregor The build https://travis-ci.org/sammyshj/privly-safari/builds/64031717 fails where it cannot find the Safari binary. I think making the test run on SauceLabs would be a viable option.

sambuddhabasu commented 9 years ago

@smcgregor The Travis CI build is successful now. It can be seen at https://travis-ci.org/sammyshj/privly-safari/builds/64033873 I have squashed all the commits and the PR can be merged now if the code looks good to you

smcgregor commented 9 years ago

Only one comment, otherwise this is ready to merge.

sambuddhabasu commented 9 years ago

@smcgregor I have added the comment regarding SAUCE_USERNAME and SAUCE_ACCESS_KEY and squashed all the commits into one.