Added links to the popover

privly / privly-safari

Official Safari Browser Extension

https://priv.ly

MIT License

13 stars 5 forks source link

Closed sambuddhabasu closed 9 years ago

sambuddhabasu commented 9 years ago

Added View History, New Message, Options, Help links to the popover.

sambuddhabasu commented 9 years ago

This PR is still not ready to be merged. The coverage is not updated and the tests have still not been added.

sambuddhabasu commented 9 years ago

@smcgregor Does the changes look good? Then, I will add tests for the same and squash the commits into one.

smcgregor commented 9 years ago

One change (commented above). Make sure you comment a summary of changes in the PR, otherwise it doesn't end up in my queue.

sambuddhabasu commented 9 years ago

@smcgregor I have updated the PR. The overall changes made in the PR:

Popover height has been incresed.
Popover links have been added for View History, New Message, Options, Help.
The links of the popover has been mentioned in a new attribute, data-popover-path
All the links are now contained under a class, popover_data
On clicking any of the newly added popover links, the openPopoverPage() function is called which opens the required page in a new window.

Should I rebase and squash all the commits now?

smcgregor commented 9 years ago

Looks good :)

Go ahead and squash and I'll merge.

sambuddhabasu commented 9 years ago

@smcgregor Squashed the commits into one.