privly / privly-safari

Official Safari Browser Extension
https://priv.ly
MIT License
13 stars 5 forks source link

Package Safari Extension #42

Closed smcgregor closed 8 years ago

smcgregor commented 9 years ago

Let's package the extension and see if there is a way to preview it from Apple's servers before publishing to the world.

sambuddhabasu commented 9 years ago

Does this mean adding the packaged Safari extension as a release in the privly-safari repo?

smcgregor commented 9 years ago

Not yet. Let's work out the build and private publishing process, then mint a new version number with a release tag in the repo.

sambuddhabasu commented 9 years ago

For releasing a Safari extension on the Safari Extensions Gallery, we need to have a Apple Developer Program Membership. More about this can be read from, https://developer.apple.com/safari/extensions/ So, I think the best thing to do is to build the extension using Extension Builder and then have a new version number with a release tag in the same repo.

smcgregor commented 9 years ago

I signed up for this a while back. Shall I attempt to package and publish to it? I want to treat the first version as more of a preview than a general release.

sambuddhabasu commented 9 years ago

I have packaged the extension and it can be downloaded from, https://github.com/sammyshj/privly-safari/blob/download/privly.safariextension/privly.safariextz?raw=true Please let me know if you can publish the package to the Safari Extensions Gallery. Thanks!

smcgregor commented 9 years ago

I'll take care of this next week. I'll also push a develop branch now that we are releasing versions.

smcgregor commented 9 years ago

I paid the $99 Apple tax and I am awaiting account activation.

sambuddhabasu commented 9 years ago

Any updates on this?

smcgregor commented 9 years ago

I invited you to be a "member" of my team, but it isn't clear what the implications of membership are. I think this site only matters insofar as we need to sign the extension with a key known to Apple?

sambuddhabasu commented 9 years ago

It looks like I can submit the Safari extension at, https://developer.apple.com/safari/extensions/submission/ Should I go ahead and do that?

smcgregor commented 9 years ago

The Foundation needs to have control of pushing new versions to users, so I suppose I'll build the extension and submit this form. Do you have a screen capture you want to use? I'll fill in the rest.

sambuddhabasu commented 9 years ago

I did not find any option of pushing a version to only the users of an organisation. I did try uploading the extension but I did not hear back from them till now. They have specified the dimensions of the images to be used. Attached are the images. rsz_logo_290 rsz_screen_shot_2015-09-06_at_51437_pm

smcgregor commented 9 years ago

It would be better to have a screen capture from a normal looking website. When you submitted the extension, was it associated with the Privly Foundation's developer account?

sambuddhabasu commented 9 years ago

Yes, I agree on having a screen capture from a normal looking website. While submitting the extension, it wasn't specified as to which account was associated with the same. I think it will be better if you can submit the extension from your side associating it to the Privly Foundation's developer account.

sambuddhabasu commented 9 years ago

The updated screen capture is attached. rsz_screen_shot_2015-09-09_at_41638_am

smcgregor commented 9 years ago
  1. I am creating a directory on https://priv.ly to host the extension.
  2. The directions indicate that I must "Include a link to a copy of your .safariextz folder on your website." The .safariextz folder will be a signed archived folder, correct? Will there always be a single current and distributed version of the extension with this as the file name?
  3. I will need to ask our host, the Open Source Lab, to change the MIME type to "application/octet-stream", with AddType application/octet-stream .safariextz

@sammyshj Can you update this page to include Safari once we have Apple distributing it?

sambuddhabasu commented 9 years ago

The .safariextz folder is already signed with my developer ID. This lets other users install the extension. There can be multiple versions out of the same extension and all of them must be signed with the developer ID.

Yes, I will update the page to include Safari. Before that, I will update this repo, to add automatic updating of the extension once the extension is hosted on https://priv.ly/

smcgregor commented 9 years ago

I signed it with the key for the privly@privly.org email and pushed it to my fork. Does this look good to you? I'll merge and deploy.

sambuddhabasu commented 9 years ago

Yes, I tested the uploaded extension with Safari and it works good. It can be merged now. Thanks!

smcgregor commented 9 years ago

You can see the staging version here. I'll deploy to priv.ly if this looks good to you. We may need to change the MIME type for the file with the host for this to work.

sambuddhabasu commented 9 years ago

Yes, this looks good to me. I will update this repo soon so that the extension can be uploaded on the Safari Extensions Gallery. Thanks.

sambuddhabasu commented 8 years ago

@smcgregor The extension is now hosted on the Safari Extensions Gallery, so, this issue can be closed now.