Transferring Maintenance

[priyadi]

Sorry for neglecting the project for so long. Currently I'm not in the position to maintain the plugin as I no longer have production installation under my responsibility.

Right now I'm putting notice to redirect visitors to @devurandom 's repository, as I see his fork is the most active. I notice @jcbrand also did the same. I hope everyone is OK with this, and good luck to everyone.

ps. @devurandom might want to detach the forked repository so the project can get all github features (issues, etc).

[devurandom]

I contacted GitHub support to detach the repositories. Will keep you updated about the progress.

I also pushed a few updates to my repository, which I had been running on my server since a while, or which I collected from your repository.

[devurandom]

GitHub just detached my repository.

[aacunha]

@devurandom i cant open a issue in your repository. After update roundcube to 1.3.0 i can access "user interface. I got error 500 in console

if i disable converse plugin all works fine.

[aacunha]

2017/07/04 14:24:44 [error] 2734#0: *50119598 FastCGI sent in stderr: "PHP message: PHP Fatal error: Call to undefined function Q() in /var/www/roundcubemail-1.3.0/plugins/converse/converse.php on line 270" while reading response header from upstream, client: 10.110.5.8, server: webmailteste.XXX.XXX, request: "GET /?_task=settings&_action=edit-prefs&_section=general&_framed=1 HTTP/1.1", upstream: "fastcgi://unix:/var/run/php5-fpm.sock:", host: "webmailteste.XXX.XXX", referrer: "https://webmailteste.XXX.XXX?_task=settings"

[aacunha]

Solved removing the call of Q function on var/www/roundcubemail-1.3.0/plugins/converse/converse.php on line 270. Works well until now. I do now if this affect another function.

[devurandom]

@priyadi I think we can close this, if you would re-parent this repository. There should be nothing left to do after that.

[diditopher]

@aacunha: As of roundcube 1.3 Q() was moved to rcube::Q() and is a shortcut function for rcube_utils::rep_specialchars_output($str, $enctype = '', $mode = '', $newlines = true)

If you take a look at the roundcube source, you will find the following comment:

/**
 * Replacing specials characters to a specific encoding type
 *
 * @param string  Input string
 * @param string  Encoding type: text|html|xml|js|url
 * @param string  Replace mode for tags: show|remove|strict
 * @param boolean Convert newlines
 *
 * @return string The quoted string
 */

I don't think it's a good idea to remove this function without knowing why it was used, as that could create security issues.

I submitted two pull-requests to @devurandom. One of them replaces Q() with rcube::Q() on roundcube >= 1.3, but he didn't merge it yet.

[devurandom]

@diditopher Sorry for taking such a long time to merge your patches. And thanks again for those!