search

priyavit / starwars-react

0 stars 0 forks source link

Review Comments #1

Open yogeshkumar05 opened 4 years ago

yogeshkumar05 commented 4 years ago

https://github.com/priyavit/starwars-react/blob/8ce02c75f8a331d71e351d2df975dd1e93597b42/public/index.html#L27

Update title to something meaningful

yogeshkumar05 commented 4 years ago

https://github.com/priyavit/starwars-react/blob/priyanka/src/App.js#L13 Is binding necessary?

yogeshkumar05 commented 4 years ago

https://github.com/priyavit/starwars-react/blob/priyanka/src/App.js#L27 Can we handle the API calls through redux?

yogeshkumar05 commented 4 years ago

https://github.com/priyavit/starwars-react/blob/priyanka/src/App.js#L31 Can this data be handled through redux?

yogeshkumar05 commented 4 years ago

https://github.com/priyavit/starwars-react/blob/priyanka/src/App.js#L65 Please create constants wherever possible (ex: static text values can be used from constants)

yogeshkumar05 commented 4 years ago

https://github.com/priyavit/starwars-react/blob/priyanka/src/router/route.js#L8 Is it justified to have this component as class?