search

prjemian / punx

Python Utilities for NeXus HDF5 files
https://prjemian.github.io/punx
5 stars 7 forks source link

switch CI to GitHub Actions workflow #136

Closed prjemian closed 2 years ago

prjemian commented 2 years ago
prjemian commented 2 years ago

On the good side, the workflow did its job. Can expand to various python3 versions (3.6 - 3.10, released today).

Conversely, the tests failed (#137). Can't merge until that is resolved.

prjemian commented 2 years ago

Great! This is all working now. Edit the badging in the README, then call for review.

prjemian commented 2 years ago

The README will be refactored in #138.

@carterbox - Can you review?

prjemian commented 2 years ago

Project has just started transitioning from external tests to in-source. All in-source tests will be pytest while the external tests are mostly (or all) unittest. This are clunkier to set up.

On Mon, Oct 11, 2021, 2:37 PM Daniel Ching @.***> wrote:

@.**** commented on this pull request.

I'm confused. Why are there both in-source tests and externals tests?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/prjemian/punx/pull/136#pullrequestreview-776604688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARMUMCEKNSQFQUBJFFT6LLUGM4HZANCNFSM5FWUFF7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.