Open prjemian opened 2 years ago
What, exactly, should this dictionary contain and how will it be used? https://github.com/prjemian/punx/blob/f0e707d1545e75b8aa5184334454849f03e24d38/punx/nxdl_manager.py#L152
Consider renaming self.xml_attributes
to self.configuration
.
This Python structure should contain content that was described in the NXDL XML file but only provide it in a way that will be useful within punx
.
How is self.xml_attributes
different from self.attributes
? Here: https://github.com/prjemian/punx/blob/f0e707d1545e75b8aa5184334454849f03e24d38/punx/nxdl_manager.py#L291
The NXDL__attribute
class says: https://github.com/prjemian/punx/blob/f0e707d1545e75b8aa5184334454849f03e24d38/punx/nxdl_manager.py#L366
Contents of NXDL <attribute>...</attribute> XML element.
NXDL__...
classes
Many terms in the API are confusing, such as the difference (in the
nxdl_manager
module) between theattributes
andxml_attributes
dictionaries. The source code could be named and organized so the different features are more recognizable to the programmer. One idea is to re-organize into submodules, similar to the subcommands of the user interface: