search

prjemian / punx

Python Utilities for NeXus HDF5 files
https://prjemian.github.io/punx
5 stars 7 forks source link

support various compression formats used by EPICS area detector #207

Closed prjemian closed 2 years ago

prjemian commented 2 years ago
lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 1e44450769a47d23124b4024534497832c82a2b0 into 9e56e3b3cf7f394d0e75532ba3158546776f0384 - view on LGTM.com

new alerts:

prjemian commented 2 years ago

apply advice from https://stackoverflow.com/questions/47359528

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 3ba2c844494bed15f7e5c42e8cec2b7329907d36 into 9e56e3b3cf7f394d0e75532ba3158546776f0384 - view on LGTM.com

new alerts:

prjemian commented 2 years ago

Accept that Codacy will report Unused import hdf5plugin. On import hdf5plugin, data compression codecs are installed and used by h5py calls from within the module.

Don't want to silence that report from flake8 configuration since we still want to detect other unused import statements.

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-0.2%) to 95.065% when pulling 2db00d8e5715cc4399322205048bbd2a62a8874c on 199-compression-formats into 9e56e3b3cf7f394d0e75532ba3158546776f0384 on main.

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 2db00d8e5715cc4399322205048bbd2a62a8874c into 9e56e3b3cf7f394d0e75532ba3158546776f0384 - view on LGTM.com

new alerts:

prjemian commented 2 years ago

@carterbox Ready for review!

prjemian commented 2 years ago

Thanks for the quick review! I recycled for re-examination.

prjemian commented 2 years ago

@carterbox Thanks! The point this covers was tracked back to a wrong version of h5py installed.

prjemian commented 1 year ago

And the (new) strip removes the optional whitespace.

On Sun, Jul 24, 2022, 9:35 PM Pete Jemian @.***> wrote:

It checks that h5py has a revision pin such as >=1.23

On Sun, Jul 24, 2022, 8:22 PM Daniel Ching @.***> wrote:

@.**** requested changes on this pull request.

In punx/tests/test_issue133.py https://github.com/prjemian/punx/pull/207#discussion_r928346188:

@@ -48,7 +48,7 @@ def test_environment_restriction():

     # test that _some_ restriction exists
     assert len(item) > len("h5py")
  • req = item[len("h5py"):]
  • req = item[len("h5py"):].strip()

What does this do?

— Reply to this email directly, view it on GitHub https://github.com/prjemian/punx/pull/207#pullrequestreview-1048725331, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARMUMBEY3OBD4OMMQP5SDTVVXT43ANCNFSM54P3NNRQ . You are receiving this because you were assigned.Message ID: @.***>

prjemian commented 1 year ago

It checks that h5py has a revision pin such as >=1.23

On Sun, Jul 24, 2022, 8:22 PM Daniel Ching @.***> wrote:

@.**** requested changes on this pull request.

In punx/tests/test_issue133.py https://github.com/prjemian/punx/pull/207#discussion_r928346188:

@@ -48,7 +48,7 @@ def test_environment_restriction():

     # test that _some_ restriction exists
     assert len(item) > len("h5py")
  • req = item[len("h5py"):]
  • req = item[len("h5py"):].strip()

What does this do?

— Reply to this email directly, view it on GitHub https://github.com/prjemian/punx/pull/207#pullrequestreview-1048725331, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARMUMBEY3OBD4OMMQP5SDTVVXT43ANCNFSM54P3NNRQ . You are receiving this because you were assigned.Message ID: @.***>