Closed prjemian closed 1 year ago
CI reports: ImportError: cannot import name 'Reporter' from 'coverage.report'
where class Reporter
was finally removed after previous deprecation.
This saves minutes from the solver phase of environment setup.
@carterbox Ready for review!
They are not required for the package, just for the testing.
On Sun, Jul 24, 2022, 8:18 PM Daniel Ching @.***> wrote:
@.**** approved this pull request.
I think these revisions work fine as implemented, but I have some optional suggestions.
In .github/workflows/unit-tests-pytest.yml https://github.com/prjemian/punx/pull/209#discussion_r928343985:
@@ -14,69 +14,53 @@ jobs: steps:
- uses: @.***
- name: Setup Miniconda
- uses: @.***
- name: Create Python ${{ matrix.python-version }} environment
- uses: @.***
Does upstream recommend using "master"? Consider using a major version instead of "master" for long term stability.
In .github/workflows/unit-tests-pytest.yml https://github.com/prjemian/punx/pull/209#discussion_r928344555:
run: |
- $CONDA/bin/conda env update --file environment.yml --name $ENV_NAME
- $CONDA/bin/conda install coverage coveralls pytest pyyaml ruamel_yaml yaml -c conda-forge --name $ENV_NAME
- $CONDA/bin/conda list -r --name $ENV_NAME
- env:
- PY_VER: ${{ matrix.python-version }}
- ENV_NAME: anaconda-test-env-py-${{ matrix.python-version }}
- micromamba install coverage pytest
- name: Install Python coveralls
- shell: bash -l {0}
- run: |
as seen: https://github.com/bleachbit/bleachbit/commit/c66b604b2702e51b215a9e768c93b099d1331fc4
- pip install coveralls pyyaml
Why not just include these two packages with the micromamba install above?
— Reply to this email directly, view it on GitHub https://github.com/prjemian/punx/pull/209#pullrequestreview-1048722380, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARMUMDFHVDJD4OWQIDXKL3VVXTOLANCNFSM54P45DDA . You are receiving this because you were assigned.Message ID: @.***>
Thanks for the quick review!