Closed prjemian closed 5 years ago
I'll have to look at it. I believe it was for either Sector 33 or Sector 7. This was for rsMap most likely. If for 33 then it is needed. Not next to the computer now.
On Jul 9, 2019 6:34 PM, Pete R Jemian notifications@github.com wrote:
@JPHammondshttps://github.com/JPHammonds Do you know if this plugin is used? If not, seems a good candidate to deprecate, then remove.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/prjemian/spec2nexus/issues/159?email_source=notifications&email_token=ACE7IMAX3JFR5MPKSM62WMLP6UOBJA5CNFSM4HYIPG3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZR2X3Y#issuecomment-509848559, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACE7IMBKE5OUABD7NVK24KLP6UOBJANCNFSM4HYIPG3A.
Pete,
This plugin was for sector 8. I am not sure how often this is used but I think that it is used intermittently.
John
From: "JPHammonds@anl.gov" jphammonds@anl.gov Date: Tuesday, July 9, 2019 at 7:51 PM To: prjemian/spec2nexus reply@reply.github.com Cc: prjemian/spec2nexus spec2nexus@noreply.github.com, Mention mention@noreply.github.com Subject: Re: [prjemian/spec2nexus] Uxml writer() needs to be implemented (#159)
I'll have to look at it. I believe it was for either Sector 33 or Sector 7. This was for rsMap most likely. If for 33 then it is needed. Not next to the computer now.
On Jul 9, 2019 6:34 PM, Pete R Jemian notifications@github.com wrote:
@JPHammondshttps://github.com/JPHammonds Do you know if this plugin is used? If not, seems a good candidate to deprecate, then remove.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/prjemian/spec2nexus/issues/159?email_source=notifications&email_token=ACE7IMAX3JFR5MPKSM62WMLP6UOBJA5CNFSM4HYIPG3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZR2X3Y#issuecomment-509848559, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACE7IMBKE5OUABD7NVK24KLP6UOBJANCNFSM4HYIPG3A.
@JPHammonds : this was for Christian Schleputz. I'd be interested to know who at 8ID say they use it. The code has not been usable for some years now. Now, the code is working in the branch, at least for the few valid test files in the repository. It needs unit tests and documentation. I'm inclined to leave the docs undone unless someone wants to use this.
Pete,
This is for a writer I see now. I know 33id needs reader for this,which or at least something that fails gracefully when it comes across it, which is now in the reader.
John
On Jul 13, 2019 9:12 PM, Pete R Jemian notifications@github.com wrote:
@JPHammondshttps://github.com/JPHammonds : this was for Christian Schleputz. I'd be interested to know who at 8ID say they use it. The code has not been usable for some years now. Now, the code is working, at least for the few valid test files in the repository.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/prjemian/spec2nexus/issues/159?email_source=notifications&email_token=ACE7IMCZBGME6EKB73KAZ6DP7KDCJA5CNFSM4HYIPG3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ34U7A#issuecomment-511167100, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACE7IMGHUBTUNCUUU7GAKWTP7KDCJANCNFSM4HYIPG3A.
Is there anything now to be fixed? The code now stops with a Python spec2nexus.plugins.uxml.UXML_Error
if the scan's UXML does not validate with the uxml.xsd
schema. Should that be relaxed to just a reported warning without an exception? Then, the writer proceeds to attempt writing with best efforts (might fail then due to problems).
Just updated spec2nexus. I am just using the reading functionality in rsMap3D & you had referenced writes. Reading the first spec file that I picked works. I even mangled one of the #UXML lines by removing a closing ‘>’ in one line. The only issue that I found was that I now have to install pyRestTable. I assume that this is needed by the writers.
John
From: Pete R Jemian notifications@github.com Reply-To: prjemian/spec2nexus reply@reply.github.com Date: Monday, July 15, 2019 at 9:40 AM To: prjemian/spec2nexus spec2nexus@noreply.github.com Cc: "JPHammonds@anl.gov" jphammonds@anl.gov, Mention mention@noreply.github.com Subject: Re: [prjemian/spec2nexus] Uxml writer() needs to be implemented (#159)
Is there anything now to be fixed? The code now stops with a Python spec2nexus.plugins.uxml.UXML_Error if the scan's UXML does not validate with the uxml.xsd schema. Should that be relaxed to just a reported warning without an exception? Then, the writer proceeds to attempt writing with best efforts (might fail then due to problems).
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/prjemian/spec2nexus/issues/159?email_source=notifications&email_token=ACE7IMDSGDWK4MUMOH7L4IDP7SD2NA5CNFSM4HYIPG3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ546NA#issuecomment-511430452, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACE7IMAFEEOSU6C5YA7A2OTP7SD2NANCNFSM4HYIPG3A.
@JPHammonds emailed:
Just updated spec2nexus. I am just using the reading functionality in rsMap3D & you had referenced writes. Reading the first spec file that I picked works. I even mangled one of the #UXML lines by removing a closing ‘>’ in one line. The only issue that I found was that I now have to install pyRestTable. I assume that this is needed by the writers.
Thanks!
@JPHammonds Do you know if this plugin is used? If not, seems a good candidate to deprecate, then remove.