prjemian / spec2nexus

Converts SPEC data files and scans into NeXus HDF5 files
https://prjemian.github.io/spec2nexus/
4 stars 7 forks source link

document the NeXus files written #192

Closed prjemian closed 2 years ago

prjemian commented 5 years ago

As suggested in https://github.com/nexusformat/definitions/issues/483#issuecomment-521053684, documentation of the NeXus file should be improved. Relevant items for this issue from the NeXus list:

prjemian commented 5 years ago

Also, when documenting the G group (and related) the documentation should refer to SPEC's documentation as much as possible and not go beyond detail provided there.

prjemian commented 3 years ago

Plan to delete the NXspecdata contributed definition by end of 2021-12-31.

prjemian commented 2 years ago
  • documentation for other NXnote groups
(bluesky_2022_1) prjemian@zap:~/.../prjemian/spec2nexus$ git grep NXnote | grep -v test | grep -v rst
src/spec2nexus/plugins/fallback.py:        nxclass = "NXnote"
src/spec2nexus/plugins/spec_common.py:    * *NXnote* group named **G** in the *NXentry* group, such as */S1/G*
src/spec2nexus/plugins/spec_common.py:                        "NXnote",
src/spec2nexus/plugins/spec_common.py:    * *NXnote* group named **counter_cross_reference** in the *NXentry* group, such as */S1/counter_cross_reference*
src/spec2nexus/plugins/spec_common.py:    * *NXnote* group named **positioners** in the *NXentry* group, such as */S1/positioners*
src/spec2nexus/plugins/spec_common.py:    * *NXnote* group named **positioner_cross_reference** in the *NXentry* group, such as */S1/positioner_cross_reference*
src/spec2nexus/plugins/spec_common.py:            h5parent, "UserReserved", "NXnote", description=desc
src/spec2nexus/plugins/spec_common.py:    * *NXnote* group named **MCA** in the *NXentry* group, such as */S1/MCA*
src/spec2nexus/plugins/spec_common.py:    * *NXnote* group **ROI** in
src/spec2nexus/plugins/spec_common.py:      in *NXnote* group named **MCA**
src/spec2nexus/plugins/unicat.py:    * *NXnote* group named **metadata** below the
src/spec2nexus/plugins/uxml.py:                nxentry, "UXML", "NXnote", desc="UXML metadata"
src/spec2nexus/writer.py:CONTAINER_CLASS = "NXnote"  # any additional freeform information not covered by the other base classes
prjemian commented 2 years ago

This issue is really about documenting the NeXus files that are written. Changing the issue name.

prjemian commented 2 years ago

Existing FIXME & TODO items now:

(bluesky_2022_1) prjemian@zap:~/.../prjemian/spec2nexus$ grep FIXME docs/source/nexus_layout/*.rst
docs/source/nexus_layout/general_tree.rst:FIXME: links have changed direction, new contents added
(bluesky_2022_1) prjemian@zap:~/.../prjemian/spec2nexus$ grep TODO docs/source/nexus_layout/*.rst
docs/source/nexus_layout/mca.rst:TODO: write
docs/source/nexus_layout/mca.rst:TODO: show with one MCA
docs/source/nexus_layout/mca.rst:TODO: show with CALIB
docs/source/nexus_layout/metadata.rst:TODO:  #U and other (#H/#V, #UXML, ...)
docs/source/nexus_layout/sample.rst:TODO
docs/source/nexus_layout/temperature.rst:TODO: ``#X`` (example calib.dat, scan 11) - Temperature Set Point
prjemian commented 2 years ago
  • the MCA group (now an NXnote) could be an NXdetector

Not a good fit for the information available now. Will leave support as-is for now.

prjemian commented 2 years ago

Moved the FIXME & TODO list to another issue (for next milestone).