search

prjemian / spec2nexus

Converts SPEC data files and scans into NeXus HDF5 files
https://prjemian.github.io/spec2nexus/
4 stars 7 forks source link

refactor mesh & MCA data parsing code #73

Open prjemian opened 7 years ago

prjemian commented 7 years ago

per #72, the code that converts the raw SPEC data into a 2-D grid resides in writer.Writer.mesh()

this code will be used in more than one place now (writer, specplot) so move it into an independent location

same for writer.Writer.mca_spectra()

from #151 : as noted in the source code: https://github.com/prjemian/spec2nexus/blob/304b0fe821d8824bb941ee2154968929c9ba7aeb/src/spec2nexus/writer.py#L238-L240

added: resolve TODO items in these files:

docs/source/nexus_layout/mca.rst:TODO: write
docs/source/nexus_layout/mca.rst:TODO: show with one MCA
docs/source/nexus_layout/mca.rst:TODO: show with CALIB
prjemian commented 7 years ago

CAUTION: Do this in steps, with unit testing on the spec2nexus.writer.Writer() code to ensure no consequences on the user community

prjemian commented 7 years ago

This work was undone in commit 2c9b541d978d19fe43b884a07200f45447cf2893. Can we bring those changes back?

prjemian commented 2 years ago

This is a refactoring of the code that potentially breaks the existing API (by changing the imports). Move to milestone for next major version number.