prjseal / PasswordGenerator

A library which generates random passwords with different settings to meet the OWASP requirements
MIT License
178 stars 43 forks source link

Can we have IDisposible ? #22

Open gbthakkar opened 2 years ago

gbthakkar commented 2 years ago

Hi, Can we have IDisposible with this public class Password : IPassword

so it can use used with "using" pattern. ??

UweKeim commented 2 years ago

If there is actually nothing to dispose, why would you want an IDisposable pattern?

gbthakkar commented 2 years ago

Hi,

Thank you for your response. I am using this in DI as transient and so thinking if it has an IDispose pattern, the object can be cleaned.

And in situations like creating objects manually at different places, we can clean after generating the password.

Or maybe we don't have to worry about memory leakage.

Regards,

Gaurang Thakkar

On Sat, Jun 18, 2022 at 5:07 PM Uwe Keim @.***> wrote:

If there is actually nothing to dispose, why would you want a IDisposable pattern?

— Reply to this email directly, view it on GitHub https://github.com/prjseal/PasswordGenerator/issues/22#issuecomment-1159449150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJOILTVOPUKURAEENBYVQQLVPWYGPANCNFSM5UEV7FJQ . You are receiving this because you authored the thread.Message ID: @.***>