search

prjseal / Umbraco-Community-Quiz

Source code for the Community Quiz website
https://communityquiz.net
Other
8 stars 16 forks source link

[UPGRADE] Umbraco & uSync #24

Closed OwainWilliams closed 2 years ago

OwainWilliams commented 2 years ago
prjseal commented 2 years ago

Hi mate, the upgrade of Umbraco would be just 2 csproj files. Your PR had 67 file changes. I had to investigate this to make sure and in the process of investigating I did the upgrade. Sorry but I'm going to close this PR. I'm sure there are other PRs you could help with.

NikRimington commented 2 years ago

@prjseal after upgrading Umbraco you should always regen the models builder models. This results in the models files changing because models build puts a hash into the comments in those files. So it should be more than 2 files as all the models builder files should update.

prjseal commented 2 years ago

Good point. I'll build the models again and commit them. Sorry @OwainWilliams we've got loads of other issues that can easily be done.

prjseal commented 2 years ago

I think my main issue was it was combined with a uSync upgrade and some of those files didn't look right. The paths for the quizzes seemed wrong