search

prman-pixar / RenderManForBlender

RenderMan for Blender render addon
MIT License
808 stars 133 forks source link

PortalLight parameters not working #629

Closed TzurH closed 3 years ago

TzurH commented 3 years ago

None of the parameters of the portal light seems to work.

https://user-images.githubusercontent.com/10125645/135704586-c108ae19-19ed-44a9-b14b-756d449e6bb0.mp4

Unless I've incorrectly set it up.

prman-pixar commented 3 years ago

Can you try the latest commit?

TzurH commented 3 years ago

Still quite buggy. Temp parameter doesn't seem to work at all, changing color param seems to cause some weird behavior that at some point, turns the light black, see clip below. Haven't tested any of the refine, shadows, and advanced params yet.

https://user-images.githubusercontent.com/10125645/135938380-2a9cd7df-4004-44a7-8bfe-a83120501532.mp4

prman-pixar commented 3 years ago

Try the latest commit.

TzurH commented 3 years ago

Color and intensity now work properly 👍 Temperature isn't working, as well as parameters under refine and shadow tabs. Have't tested advanced tab parameters.

prman-pixar commented 3 years ago

Try the latest commit. Was not overriding some parameters, if they were not set to default.

TzurH commented 3 years ago

Shadow tab parameters aren't working, restarting IPR doesn't help.

Shadow is enabled on PxrDome, but when I disable shadows via PortalLight or if I limit the shadow distance, for instance, there's no effect.

prman-pixar commented 3 years ago

@TzurH shadow distance seems to work for me as well as Enable Shadows. Turning off Enable Shadows on the portal light removes the shadow for me. Note, that if any of the shadow parameters are at default on the portal light, it uses/copies the values from the dome light.

TzurH commented 3 years ago

Hmm, I'm not getting the same result. I've changed all of the shadow values to be different from the defaults. Maybe I'm doing something wrong. I have an HDR map plugged into the dome light, not sure if that is of any difference.

https://user-images.githubusercontent.com/10125645/136138491-2d670299-43d4-49ac-af40-5ac3d4554f00.mp4

prman-pixar commented 3 years ago

@TzurH This is the scene that I'm using. I can change the shadow color, enable/disable shadows, and the shadow distance. portal_test.zip

TzurH commented 3 years ago

Had to remove the lights from my test scene and add them back. Can confirm works. Thanks for the fix! 👍