search

prman-pixar / RenderManForBlender

RenderMan for Blender render addon
MIT License
803 stars 134 forks source link

Check if Blender version is supported #672

Closed King-Wally closed 1 year ago

King-Wally commented 1 year ago

I've added a check that will display an error message about the blender version when the user tries to enable the addon in a Blender version that is using python 3.10. I've also added the supported Blender versions to the read me. Screenshot 2023-04-23 162412

prman-pixar commented 1 year ago

@King-Wally thanks for the PR. I wonder if we can modify this so that we can have a list of supported python versions.

My thinking is that in envconfig_utils, we stash a list of python versions that are available in the RmanEnvConfig class. This list can be built up from the available versions in $RMANTREE/lib/python[x.x]. We then check sys.version_info against this list in preferences.py. This way, we don't have to modify preferences.py every time we add a new python version.

King-Wally commented 1 year ago

That sounds like a better long term solution, but I'm afraid that this is not something I'm able to code. I created this pull request because I saw a lot of people using an unsupported version of blender and getting the RMANTREE error. This was the easiest way I found to give them a more useful error.

prman-pixar commented 1 year ago

OK, thanks. I'll close this for now, but I'll make sure to add something similar for the next release.