search

prmr / Creco

Recommendation System for Consumer Products
Apache License 2.0
6 stars 2 forks source link

Incorrect mapping for product names #20

Closed forgues closed 10 years ago

forgues commented 10 years ago

We are having difficulty finding the human-readable product names. For example, in the laptop equivalence class, there is the product name "2344BKU (Black)". The product can be found here:

http://www.consumerreports.org/cro/electronics-computers/computers-internet/computers/laptop-ratings/model/overview/lenovo-2344bku-black-d80965.htm

This page contains "Product Name ThinkPad T430 2344BKU Notebook", which is the string we want, but we can't find it through the Product API. We should investigate what's the correct field in the JSON file and make sure it's loaded in the Product object.

forgues commented 10 years ago

Since the product name "ThinkPad T430 2344BKU Notebook" comes from an external source, it isn't in the JSON file at all. It seems like the CR webpage for the product concatenates brand "Lenovo" and display name "2344BKU (Black)" as the product name.

mangalagb commented 10 years ago

So, we could create a new field concatenate these two fields and use this to query lucene ?

prmr commented 10 years ago

I've just assigned this to Milestone 0.2. mangalagb will solve this. I wouldn't say this is a bug, rather a problem in the data for which we need workaround functionality.

forgues commented 10 years ago

To reply to mangalagb, yes we could search for brand + product name in lucene. But I would say this is more of a display issue than a search issue. We already return all products within an equivalence class anyways, we just want to have reasonable names to display to the user instead of "2344BKU".

mangalagb commented 10 years ago

Since other classes may require the use of display name of a product, I have made changes to it in the Product class itself not just lucene. Now, getName method returns a much better looking name combining the brand name as well fas the original display name for the product. The code for this is in branch Productnames. If everyone is satisfied with this modification, I shall close this issue.

mangalagb commented 10 years ago

Merged changes into master