prmr / Creco

Recommendation System for Consumer Products
Apache License 2.0
6 stars 2 forks source link

Unify logging #23

Closed prmr closed 10 years ago

prmr commented 10 years ago

All the logging in Creco should be done through slf4j.

asutcl commented 10 years ago

Logging with slf4j has been done for the AttributeExtractor.

priyasidhaye commented 10 years ago

All logging done through class CrecoLogger.

prmr commented 10 years ago

The last two commits seem to have broken the build. Let's simply complete this issue by replacing all logging and system calls by calls to the sl4j logger as is done in AttributeExtractor. Please do this on a separate branch.

priyasidhaye commented 10 years ago

Okay. I will do it on a separate branch and push it

prmr commented 10 years ago

I saw some churn on the classpath and settings files, perhaps that caused the problem? slf4j was already on the classpath.

priyasidhaye commented 10 years ago

Replaced printlns with LOG debug statements.