Test the search classes

prmr / Creco

Recommendation System for Consumer Products

Apache License 2.0

6 stars 2 forks source link

Test the search classes #29

Closed forgues closed 10 years ago

forgues commented 10 years ago

Should have unit tests for ProductSearch and CategorySearch, which cover basic search functionality, such as querying by exact string match, by string with typo, etc.

forgues commented 10 years ago

Tests have been merged into the master branch.

prmr commented 10 years ago

I have two test failures: TestProductSearch. testExactStringMatch TestProductSearch. testTypoStringMatch commit: 6fbaca3a1f74a43e1893267b99478e6d6197b51c

forgues commented 10 years ago

Those two tests perform assertions based on the product's name, e.g. "iPhone 5s (16GB) (Verizon)". I think the product name was changed to be the concatenation of brand+name now, e.g. "Apple iPhone 5s (16GB) (Verizon)". At least, that's my guess why these two tests would start failing now. I should have time to fix them later today.