search

prmr / Creco

Recommendation System for Consumer Products
Apache License 2.0
6 stars 2 forks source link

New UI Layout #43

Closed prmr closed 10 years ago

prmr commented 10 years ago
ceipher commented 10 years ago

@enewe101 I manually merged the new UI to master branch. So master is fresh now, feel free to use it. @prmr I deleted the UILayout_M3 branch (backup in my local machine), because I had great difficulty on auto-merge it. So everything is in master now

enewe101 commented 10 years ago

Ok great. I'll pull that in to #44, and then create an Integration branch from that. I'll send out a wider message when that's ready.

On Thu, Mar 20, 2014 at 5:36 PM, ceipher notifications@github.com wrote:

@enewe101 https://github.com/enewe101 I manually merged the new UI to master branch. So master is fresh now, feel free to use it. @prmr https://github.com/prmr I deleted the UILayout_M3 branch (backup in my local machine), because I had great difficulty on auto-merge it. So everything is in master now

Reply to this email directly or view it on GitHubhttps://github.com/prmr/Creco/issues/43#issuecomment-38224028 .

enewe101 commented 10 years ago

@ceipher -- I believe everything is complete here, and that there were no changes since your last post. If so, go ahead and close the issue. Otherwise let me know what is left to do.

ceipher commented 10 years ago

Just finished.

enewe101 commented 10 years ago

Good stuff! Is everything merged into Integration?

ceipher commented 10 years ago

Yes. They are in integration now. I notice another bug, when you change the features, the URL will point to current page. Should we move it to be fixed in Milestone 4?

ceipher commented 10 years ago

Never mind, I think I figured out...will commit in 1 minutes

ceipher commented 10 years ago

This is because the ranking algorithm returned an empty list. So I don't know if it's a bug or not. I made an extra check to ensure that if the list is empty, the product list just remained the same. Solved for M3

MariamN commented 10 years ago

@ceipher yes this was a bug, which is fixed now. Ranking algorithm will always return a list of products now.

MariamN commented 10 years ago

@Ceipher, i pushed to Integration branch. There seem to be a problem with the displaying of the products. The new list of products (productsToDisplay) is not displayed, instead it is always showing the same alphabetical sorted product list.

ceipher commented 10 years ago

@MariamN sorry, my fault. I will fix it

ceipher commented 10 years ago

Fixed