prmr / Creco

Recommendation System for Consumer Products
Apache License 2.0
6 stars 2 forks source link

FilterandReturn in RankedFeatureProducts #51

Closed asutcl closed 10 years ago

asutcl commented 10 years ago

The FilterandReturn method compares based on toString() values. This should not be. Please use the checks and getters to compare against primitive values. This lead to crashes in the test, I have temporarily implemented a toString() for TypedValue for milestone 0.2.

prmr commented 10 years ago

This class also needs to be cleaned up and moved to the logic package.

prmr commented 10 years ago

This will be completely refactored. Closed.