search

prmr / Creco

Recommendation System for Consumer Products
Apache License 2.0
6 stars 2 forks source link

Update the tests in logic #71

Closed prmr closed 10 years ago

prmr commented 10 years ago

Update the tests so they no longer use the deprecated methods and constructors.

prmr commented 10 years ago

TestScoredAttribute breaks in the master branch!

asutcl commented 10 years ago

There aren't any test in it I think. It fails because I think I didn't add the class to the test file. My mistake for not running the test though before commiting

prmr commented 10 years ago

Can you fix it?

asutcl commented 10 years ago

Yeah sorry I just didn't notice this snippet of code was in the branch I pushed. I've been sick for a week and my brain is a big pile of mush.

I've fixed it but I get a test error on @Test public void testProductLinks() in TestProduct when it compares a dead link to the url.

So I haven't pushed yet was this error also there before?

asutcl commented 10 years ago

Nvm error isn't there anymore I will fix this now.