search

prmr / Creco

Recommendation System for Consumer Products
Apache License 2.0
6 stars 2 forks source link

Correlation on non strictly numeric attributes #84

Closed asutcl closed 10 years ago

asutcl commented 10 years ago

Currently if you pass an attribute ID to the AttributeCorrelator and there are some non numerical attributes in the product set, the Attribute throws an error.

For now I will add a method in AttributeCorrelator so you can call AttributeCorrelator with a threshold which represents the minimum ratio of numerical attributes needed in order to computer the correlation. This will allow to compute correlations on a broader set of attributes while not hiding the fact that the correlation is possibly computed on only a subset of valid attributes.

If any one has any better ideas pleas let me know.

forgues commented 10 years ago

Since the threshold should apply to all methods (computeCorrelation and computeAttributeDirection), I think it would be best to pass the threshold to the constructor instead of a new method. I can implement this right now if you want.

asutcl commented 10 years ago

Its fine I am working on it now and I am almost done. thanks

asutcl commented 10 years ago

Merged into master.