search

prmr / Creco

Recommendation System for Consumer Products
Apache License 2.0
6 stars 2 forks source link

Bug in master branch - product ranking #96

Closed MariamN closed 10 years ago

MariamN commented 10 years ago

I just pulled out of master and it seems there is a bug. When selecting any features products are not getting ranked. is anyone else having this issue

priyasidhaye commented 10 years ago

I tried it now. The features get ranked but every other product seems to vanish from the product view.

enewe101 commented 10 years ago

Hi @MariamN, yeah that's annoying. Here's what I suggest:

I made a temporary master branch called tmp-master. It breaks off from master before the offending commit. Please develop with that as a basis, and when you're ready, merge into that.

Once @mangalagb fixes the real master, we'll merge these, and put the issue behind us.

This is a good opportunity to remind people: please test before you merge to master (or push anything for that matter)! And definitely before merging to master, do some manual tests that Priya wrote to make sure the app is running as expected!

enewe101 commented 10 years ago

@mangalagb -- this is getting in the way of people's work -- we need a working master. Are you taking care of it?

Because people might have branches based on this broken master ( @MariamN does) I can't simply roll it back.

The problem seems to come in your commit bfc4c216789.

mangalagb commented 10 years ago

Im lookinginto it now..

mangalagb commented 10 years ago

Can you please pull the latest master and tell me if the problem persists? I have fixed the bug related to disappearing products. But now, when you select any feature, the image thumbnail disappears. I'm looking at the ajax response to fix this.

enewe101 commented 10 years ago

@mangalagb I just pulled, and it does seem like the bug is gone. We aren't getting any thumbnails anymore though...but it's good that we have a stable master again!

Do you think you'll be able to get the thumbnail images working in time for the release of milestone 0.4? It seemed like we were close, since we thumbnails showing up before (although the bug cropped up at the same time). Let me know what you think.

mangalagb commented 10 years ago

The thumbnails disappear when we reload the view. I have pinpointed the problem to sendFeatures() method in featuresforms.js. Am working on it now.

mangalagb commented 10 years ago

I am not sure how to update the view after the features have been selected. I'll talk to Shou tomorrow in class and fix this. I think this issue can be closed.