Fresh set of data set error on associateProducts

[nishanthtgwda]

I am trying to run the application with the new data set(6k products) and seems like the while building the product set, the exception is thrown at associateProducts() , particularly at this statement, category.addProduct(lProduct). I was trying to write test cases with this data sets and it would just throw an exception at this. @enewe101

[enewe101]

Hey @nishanth1991 -- thanks for the heads up!

clarification question:

Is there an error while building the data objects while running the application, or is it only while running JUnit tests? If there is an error during JUnit tests, is it a true error (what is the exception?) or a failure? True errors get a red 'x' and failures get a blue 'x'.

If it's a failure while running JUnit, then probably nothing is severely amiss -- it means that we have tests that assume that the testing data are being given. In fact, we should always be testing with the same testing data, since many tests are built around making sure that the testing data gets correctly represented by the built data objects.

But of course, if there is a true error happening (either on application startup or in tests), we'll want to write some test-cases to specifically isolate these errors, and then adapt the code so the tests pass.

If there is a true error, I'll look into it -- but it will have to be post milestone 0.4 though -- sorry!

[nishanthtgwda]

@enewe101 : Figured out the error. The new data set has extra products and those weren't matching to the ones in dead_links. A small check statement got it working.

@prmr : Creco now works perfectly with the updated data set as well

Total number of categories is now 335 and Total number of products is 8053

[nishanthtgwda]

This issue can be close now I guess

[enewe101]

Cool, glad to hear it was a minor problem!