prmr / JetUML

A desktop application for fast UML diagramming.
GNU General Public License v3.0
625 stars 125 forks source link

#437 Fix Downstream ImplicitParameterNode removal when a ConstructorEdge removed #449

Closed maddy0218 closed 2 years ago

maddy0218 commented 2 years ago

SequenceDiagramBuilder.getCoRemovals() now includes line which checks whether the explicit parameter is an object of type ConstructorEdge, and if so, removes downstream objects of type ImplicitParameterNode. This ensures that when a constructor edge is removed, its downstream implicit parameter nodes are not also removed, in order to be consistent with the effects of deleting call edges. A unit test for this specific change was also produced.

Below are images showing the fix: image

image