search

prmr / Solitaire

Implementation of the Solitaire card game with JavaFX
GNU General Public License v2.0
26 stars 38 forks source link

[Question] Final variables #17

Closed AllanWang closed 6 years ago

AllanWang commented 7 years ago

For consistency, shouldn't all of these be marked as final?

https://github.com/prmr/Solitaire/blob/v0.4/src/ca/mcgill/cs/stg/solitaire/model/GameModel.java#L97

https://github.com/prmr/Solitaire/blob/v0.4/src/ca/mcgill/cs/stg/solitaire/model/GameModel.java#L416

prmr commented 6 years ago

Yes. Fixed as part of #20.