search

pro-crafting / Jasper-report-maven-plugin

A fast jasper report maven plugin
Apache License 2.0
29 stars 3 forks source link

Update slf4j to version 2 #9

Closed Postremus closed 1 year ago

Postremus commented 1 year ago

relates to https://github.com/pro-crafting/Jasper-report-maven-plugin/pull/6

Can slf4j be updated to version 2? This should have no effect on users of the plugin, since afaik no dependency of maven plugins is leaking onto the user classpath.

Lets test this out.

Postremus commented 1 year ago

https://www.slf4j.org/faq.html#changesInVersion200

slf4j 2 would require updating logging frameworks. We are right now on maven 3.5.2, not sure if we can update anything there.

Is slf4j even needed as explicit dependency?

marschall commented 1 year ago

Is slf4j even needed as explicit dependency?

I don't think so as we do not have dependencies in the plugin source code.