search

pro-crafting / Jasper-report-maven-plugin

A fast jasper report maven plugin
Apache License 2.0
24 stars 2 forks source link

JasperReports 7 compatibility #92

Open Postremus opened 2 months ago

Postremus commented 2 months ago

JR 7 has just been released. https://repo1.maven.org/maven2/net/sf/jasperreports/jasperreports/7.0.0/ https://github.com/TIBCOSoftware/jasperreports/tree/release-7.0.0?tab=readme-ov-file#jasperreports-library-700-change-log

We should make sure this plugin is compatible with the newest version.

At least following tasks need to be done, in addition to some nice to haves:

KeatsPeeks commented 2 weeks ago

Hi, is there any progress or ETA on this issue ? Thanks.

RainerGanss commented 1 week ago

@Postremus Shouldn´t you be able to check the second box by definition? "Implement compatibility with JR 7" We are waiting for this release <3

rturner-edjuster commented 1 week ago

Comments on the "optional" items listed here:

renaming: I think it would make sense to follow the naming convention -- however, it will cause the artifact name to change -- no doubt causing confusion for users -- however, since you are bumping the major version to 4.0.0, it would be the right time to do it

dropping Maven 3.5.2 support: Many of the plugins require Maven 3.6.3 as a base -- moving the minimum to 3.9 might be a bit drastic unless you have a specific reason to do so -- I would suggest keeping at least 3.6.3 as a base minimum at least until Maven 4.0 is in wide use

BTW, any way anyone can help with "implement compatibility with JR 7" ? Do you have "more details" on what's needed to be done?

RainerGanss commented 1 week ago

@rturner-edjuster If you look at the title "JasperReports 7 compatibility" I think that is all this PR does to be honest.

RainerGanss commented 1 week ago

Oh, my bad. I thought this was an PR ... sorry for the mess

stoufix commented 1 day ago

Hi, is there any progress or ETA on this issue ? Thanks.

i create a PR for this issue

RainerGanss commented 1 day ago

I was doing the same. So I can stop working on that. Thx!

RainerGanss commented 1 day ago

102

RainerGanss commented 1 day ago

We´ll test the PR next Monday with our production reports. I´ll get back here.

RainerGanss commented 1 day ago

@rturner-edjuster @Postremus with respect to the optional renaming. If you do this, please consider providing the relocation information in the maven pom.

https://maven.apache.org/guides/mini/guide-relocation.html

That way in maven central everyone can see, that the artefact was moved and where it moved to. It´s a bit tricky, since you have to publish a pom under the old group/arty-id with that relocation information. And 3.9 as a requirement is really quite harsh.

stoufix commented 1 day ago

We´ll test the PR next Monday with our production reports. I´ll get back here.

Currently, I haven't found any issues related to this migration in the non-production environment. We are planning a load test in two weeks under production conditions. I will share the results here. 😉

rturner-edjuster commented 14 hours ago

@rturner-edjuster @Postremus with respect to the optional renaming. If you do this, please consider providing the relocation information in the maven pom.

https://maven.apache.org/guides/mini/guide-relocation.html

That way in maven central everyone can see, that the artefact was moved and where it moved to. It´s a bit tricky, since you have to publish a pom under the old group/arty-id with that relocation information. And 3.9 as a requirement is really quite harsh.

That would be up to @Postremus -- I was just commenting to provide feedback from a user. However, I agree with the suggestion of making it easier to map the transition.

rturner-edjuster commented 14 hours ago

My local testing of @stoufix 's PR #102 is successful. Seems to work as expected. @Postremus Are you able to comment on direction here? Do you want to make the other changes in your TODO list for this issue? (I can work on at least one of them and post a separate PR for it if you would like to do them.)