search

pro-well-plan / pwptemp

pwptemp
https://pro-well-plan.github.io/pwptemp/
GNU Lesser General Public License v3.0
58 stars 23 forks source link

Casings #15

Open elyngvi opened 5 years ago

elyngvi commented 5 years ago

Added a to-do task. Today the model accepts an arbitrary 3 casings, and it is not straight forward to define them, as you have to give the shoe depths one place and the dimensions somewhere else.

I suggest you take away all the 9 (?) casing related properties, and replace them with one, "casings" which takes an array of any number of casings, defined by depth and diameters: 'casings': [{'od': num, 'id': num, 'md': num}, ...] This array could be sorted by md for example, to make sure the casings are in the right order. You would have to rewrite your code a bit to fit that change, but it would be a great benefit.

jcamiloangarita commented 5 years ago

Excellent suggestion! Hopefully this will be available for the next release.

jcamiloangarita commented 5 years ago

All the parameters are available into the same dictionary and the casings names have been changed for a better understanding.

Additionally, a function pwptemp.input.info( ) was created to get information regarding all the parameters.