pro100svitlo / FingerprintAuthHelper

A small library that allows You to easily manage fingererprint authentication inside your Activity or Fragment on devices with fingerprint scanner and Android M and higher. Min sdk 14
450 stars 70 forks source link

(Hopefully) some improvements to Kotlin code and some general cleanup #7

Closed Bombo closed 7 years ago

Bombo commented 7 years ago

I'm currently adapting Kotlin myself and in our current project we needed Fingerprint authentication, so I've stumbled upon your library and noticed some things, that weren't Kotlin enough for me. ;)

Everything is up for discussion, of course.

You should get all the information from my commit messages, but overall what I did is:

Let me know what you think!

pro100svitlo commented 7 years ago

this is little bit different theme, but maybe you have some ideas about this issue?

pro100svitlo commented 7 years ago

thanks for your job :)

Bombo commented 7 years ago

No problem at all. This was fun! :)