pro3d-space / PRo3D

PRo3D, short for Planetary Robotics 3D Viewer, is an interactive 3D visualization tool allowing planetary scientists to work with high-resolution 3D reconstructions of planetary surfaces.
http://pro3d.space/
GNU Affero General Public License v3.0
38 stars 2 forks source link

Geologic Surface Creation #19

Open chris-traxler opened 3 years ago

chris-traxler commented 3 years ago

Create a surface between polylines used for delineation of surface features. This can also be used in tunnel monitoring to create surfaces between geologic interpretations of more tunnel faces. Task separation:

Requirement P3D-M012

LauraFritz14 commented 3 years ago

Branch: develop/features/geologicSurfaceCreation
Commit 62436cf Testdata: file://euclid.vrvis.lan/InOut/PRo3D/TunnelFaceSequence.7z

Here is my scene file: Z:\projects\20-ExoMars_PanCam_3D_Vision_2021\data\GeologicSurfaceCreation

selection

To create a new geologic surface select two annotations via multiselection (click on the cube in front of the annotations name) in the Annotations tab.

mesh

Then push the +-button (A) in top of the GeologicSurfaces tab to get an new geologic surface in the 3d view and in the listing (B). The listing (right) shows all meshes in the scene. Under the mesh's name is a little menu:

You can select a mesh by clicking on it's name, which turns the color to green. Then you can see the mesh's properties in the Properties panel below:

known rendering issue:

issue

The geologic surfaces are rendered in drawing order.

chris-traxler commented 3 years ago

Everything works fine as described above by @LauraFritz14. The current mesh creation method by connecting points of two polylines works well enough and can be included in the next release. It is hard to avoid artefacts that result from two polylines that do not match ideally. Artefacts are then visible when increasing the transparency.

Geologic Surfaces 2

I suggest to drop the subtask "Connect endpoints of polylines and triangulate in discrete steps" because it would not improve the situation of badly matching polylines.

chris-traxler commented 3 years ago

There is a small usability issue. When navigating to a geologic surface, PRo3D assumes a view that corresponds to the polyline that was selected second. So the surface is viewed edge on.

https://user-images.githubusercontent.com/5574563/117028764-4e48da00-acfe-11eb-8d4c-26d8bf50e559.mp4

LauraFritz14 commented 3 years ago

Commit 5eeb3f1

hp

Added "Set Homeposition" button to properties panel. You can set the current camera view as FlyTo view for the selected geologic surface to solve the problem described by @chris-traxler above.

chris-traxler commented 3 years ago

I successfuly tested the "Set Homeposition" button for different geologic surfaces and for different viewpoints.

ThomasOrtner commented 3 years ago

https://user-images.githubusercontent.com/21270851/125478477-fdc49b4a-6bc9-49f9-a8fe-e600b45e6737.mp4

I tested the geological surface and I have to remarks

1) there are numerical issues with Martian data, tested it with a Shaler Scene 2) there should be some hints on how to create a geological surface in the respective tab when nothing is selected, e.g. nothing is selected - "(multi) select two annotations to connect", one is selected - "1 of 2 annotations selected", ...

ThomasOrtner commented 2 years ago

is this solved in any newer version? thanks