pro3d-space / PRo3D

PRo3D, short for Planetary Robotics 3D Viewer, is an interactive 3D visualization tool allowing planetary scientists to work with high-resolution 3D reconstructions of planetary surfaces.
http://pro3d.space/
GNU Affero General Public License v3.0
38 stars 2 forks source link

Define which global settings should be saved with sequenced bookmarks #371

Closed RebeccaNowak closed 8 months ago

RebeccaNowak commented 9 months ago

gpaar

Global settings shall remain valid and undergo a warning if changed upon sequence formation. As a first case, I came across the fact that for some reason the coordinate system changed between Mars and None between different bookmarks. This must not be the case and causes confusion, as e.g. transforming surfaces reacts differently under different coordinate systems. It is recommended to warn the user at least.

RebeccaNowak commented 9 months ago

Currently, the whole Reference System is saved with sequenced bookmarks. This means the following parameters:

We can remove any or all of them from sequenced bookmarks, or show warnings. However, I would not recommend showing warnings for each of them, as that would be overwhelming. Looking at the list, my suggestion is:

Other global settings that are currently saved with sequenced bookmarks are the following (in ViewConfigModel):

Should we remove any or all of these settings from sequenced bookmarks?

RebeccaNowak commented 9 months ago

@gpaar Please clarify which global settings should be removed or have warnings attached. Don't hesitate to ask if anything is unclear.

gpaar commented 9 months ago

With "coordinate system" I meant "Planet" anyway. So removing this from SB is fine. Global settings that do not affect a specific drawing case shall be removed as well. nearPlane and FarPlane shall be kept in SB, as they affect the current drawing, same with all features of current drawings, such as dnsPlaneSize and drawOrientationCube. The global / default setting of various GUI parts shall not be affected by SBs. e.g. the default size of scale bars, or the default annotation color etc.